pkg/49262: Firefox compile fails at AString.o

[b***@pocketservices.de]

Number: 49262
Category: pkg
Synopsis: Firefox compile fails at AString.o
Confidential: no
Severity: serious
Priority: medium
Responsible: pkg-manager
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Thu Oct 09 06:35:00 +0000 2014
Originator: Benjamin Lorenz
Release: NetBSD 6.1_STABLE

System: NetBSD netvm.pocketservices.de 6.1_STABLE NetBSD 6.1_STABLE (GENERIC) #0: Mon Jul 28 17:58:37 CEST 2014 ***@netvm.pocketservices.de:/usr/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
netvm$ pwd
/usr/pkg/src/www/firefox
netvm$ head distinfo
$NetBSD: distinfo,v 1.160 2014/10/05 01:59:08 ryoon Exp $

SHA1 (firefox-32.0.3.source.tar.bz2) = 1f831147365478e353212714038e812ca3e9fe42
RMD160 (firefox-32.0.3.source.tar.bz2) = f09e2cc92a35f0f3e88079d063c22bf16215327a

Compile error:

In file included from /usr/include/ctype.h:74:0,
from ../../dist/system_wrappers/ctype.h:3,
from /usr/pkg/src/www/firefox/work/mozilla-release/media/libstagefright/frameworks/av/media/libstagefright/foundation/AString.cpp:17:
/usr/pkg/src/www/firefox/work/mozilla-release/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected unqualified-id before 'int'
void tolower();

[r***@NetBSD.org]

Synopsis: Firefox compile fails at AString.o

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Sat, 11 Oct 2014 18:42:40 +0000
Responsible-Changed-Why:
mine

[Ryo ONODERA]

The following reply was made to PR pkg/49262; it has been noted by GNATS.

From: "Ryo ONODERA" <***@netbsd.org>
To: gnats-***@gnats.NetBSD.org
Cc:
Subject: PR/49262 CVS commit: pkgsrc/www/firefox
Date: Sat, 18 Oct 2014 17:56:35 +0000

Module Name: pkgsrc
Committed By: ryoon
Date: Sat Oct 18 17:56:35 UTC 2014

Modified Files:
pkgsrc/www/firefox: distinfo mozilla-common.mk
Added Files:
pkgsrc/www/firefox/patches:
patch-media_libstagefright_frameworks_av_include_media_stagefright_foundation_AString.h

Log Message:
Fix build under NetBSD 6.

* Avoid conflict of tolower function, Thank you, tsutsui@ (PR pkg/49262).
* GCC 4.6 is required to support nullptr at least.


To generate a diff of this commit:
cvs rdiff -u -r1.163 -r1.164 pkgsrc/www/firefox/distinfo
cvs rdiff -u -r1.44 -r1.45 pkgsrc/www/firefox/mozilla-common.mk
cvs rdiff -u -r0 -r1.1 \
pkgsrc/www/firefox/patches/patch-media_libstagefright_frameworks_av_include_media_stagefright_foundation_AString.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

[r***@NetBSD.org]

Synopsis: Firefox compile fails at AString.o

State-Changed-From-To: open->feedback
State-Changed-By: ***@NetBSD.org
State-Changed-When: Sun, 19 Oct 2014 01:31:03 +0000
State-Changed-Why:
Please try latest www/firefox.