pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on netbsd-5/i386

Discussion:

j***@mylinuxisp.com

2013-09-20 03:00:00 UTC

Number: 48224
Category: pkg
Synopsis: x11/xscreensaver can't find GTK, GDK-Pixbuf on netbsd-5/i386
Confidential: no
Severity: serious
Priority: high
Responsible: pkg-manager
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Fri Sep 20 03:00:00 +0000 2013
Originator: John D. Baker
Release: NetBSD-5.2_STABLE/i386, pkgsrc-HEAD (pre-pkgsrc-2013Q3)

On netbsd-5/i386 system (w/modular xorg, if that's important), building
x11/xscreensaver fails as follows:

In the configure phase:

[...]
checking for uview_direction in -lgle... yes
checking for gdk-pixbuf-2.0... no
checking for gdk_pixbuf usability... no
checking for X11/xpm.h... yes
[...]
config.status: executing default-1 commands
config.status: executing default-2 commands
configure: WARNING: unrecognized options: --with-zippy, --with-xml

#################################################################

Warning: The GTK libraries do not seem to be available; the
`xscreensaver-demo' program requires them.

Warning: The GDK-Pixbuf library was not found.
The XPM library is being used instead.

Some of the demos will not use images as much as they could.
You should consider installing GDK-Pixbuf and re-running
configure. (GDK-Pixbuf is recommended over XPM, as it
provides support for more image formats.)
dpkg: not found
dpkg: not found
dpkg: not found

#################################################################

User programs will be installed in /usr/pkg/bin/
Screen savers will be installed in /usr/pkg/libexec/xscreensaver/
Configuration dialogs will be installed in /usr/pkg/libexec/xscreensaver/config/
System-wide default settings will be installed in /usr/pkg/lib/X11/app-defaults/

It then tries to continue with the build phase anyway:

===> Building for xscreensaver-5.22
usage: make [-BeikNnqrstWX] [-D variable] [-d flags] [-f makefile]
[-I directory] [-J private] [-j max_jobs] [-m directory] [-T file]
[-V variable] [variable=value] [target ...]
*** Error code 5

Stop.
make: stopped in /d0/build/pkgsrc/x11/xscreensaver/work/xscreensaver-5.22
*** Error code 1

Stop.
make: stopped in /x/pkgsrc/x11/xscreensaver
*** Error code 1

Stop.
make: stopped in /x/pkgsrc/x11/xscreensaver

The gtk2+ and gdk-pixbuf packages were installed previously (as
dependencies of previous packages):

$ pkg_info -a | grep ^g[td]k
gdk-pixbuf2-2.28.2 Image loaders for gtk2
gtk2+-2.24.20nb1 GIMP Toolkit v2 - libraries for building X11 user interfaces
gdk-pixbuf2-xlib-2.28.2 Image loaders for gtk2

The section(s) of the ./configure script that checks for gdk-pixbuf
seems to be correct. Executing the commands manual returns success
(0 exit code), but apparently fail in the script.

x11/xscreensaver builds correctly on NetBSD-6.1_STABLE/i386.
On netbsd-5/i386 (amd64?, others?) and pkgsrc-HEAD as of about
201309200000Z, attempt to build x11/xscreensaver.

David Holland

2013-09-20 05:50:00 UTC

Permalink

The following reply was made to PR pkg/48224; it has been noted by GNATS.

From: David Holland <dholland-***@netbsd.org>
To: gnats-***@NetBSD.org
Cc:
Subject: Re: pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on
netbsd-5/i386
Date: Fri, 20 Sep 2013 05:45:21 +0000

Post by j***@mylinuxisp.com
checking for gdk-pixbuf-2.0... no
checking for gdk_pixbuf usability... no

I think that's intentional; there's a separate xscreensaver-demo
package that does depend on gdk-pixbuf2. (and gtk2 and some other
bits)

Post by j***@mylinuxisp.com
===> Building for xscreensaver-5.22
usage: make [-BeikNnqrstWX] [-D variable] [-d flags] [-f makefile]
[-I directory] [-J private] [-j max_jobs] [-m directory] [-T file]
[-V variable] [variable=value] [target ...]
*** Error code 5

This, however, is a different problem; something is passing gmake
options to bmake.

We had a problem with this with -current owing to some inadvisable
modifications to make, but these shouldn't (AFAIK) affect you on 5.x
...and also I thought that mess had been fixed.

I don't see anything obvious in the package that should cause this
behavior, nor is the package set to require gmake. Do you maybe have
MFLAGS set in the environment?

Post by j***@mylinuxisp.com
The section(s) of the ./configure script that checks for gdk-pixbuf
seems to be correct. Executing the commands manual returns success
(0 exit code), but apparently fail in the script.

(The purpose of the buildlink infrastructure is to make that happen
for packages the build isn't supposed to see...)

--
David A. Holland
***@netbsd.org

John D. Baker

2013-09-20 11:50:00 UTC

Permalink

Post by David Holland

This, however, is a different problem; something is passing gmake
options to bmake.
We had a problem with this with -current owing to some inadvisable
modifications to make, but these shouldn't (AFAIK) affect you on 5.x
...and also I thought that mess had been fixed.
I don't see anything obvious in the package that should cause this
behavior, nor is the package set to require gmake. Do you maybe have
MFLAGS set in the environment?

I am not doing anything with MFLAGS (and was not aware of it until you
mentioned it--and have not found it mentioned anywhere else).

Unless you mean MAKEFLAGS, in which case, no I'm not manipulating
that at all.

The only things I've changed that should affect it are in my "mk.conf":

PKG_DEFAULT_OPTIONS+=pam ssl -cups -pulseaudio
PKG_OPTIONS.xscreensaver+=webcollage

--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645

John D. Baker

2013-11-04 02:45:01 UTC

Permalink

Post by David Holland

Post by j***@mylinuxisp.com
===> Building for xscreensaver-5.22
usage: make [-BeikNnqrstWX] [-D variable] [-d flags] [-f makefile]
[-I directory] [-J private] [-j max_jobs] [-m directory] [-T

file]

Post by j***@mylinuxisp.com
[-V variable] [variable=value] [target ...]
*** Error code 5

This, however, is a different problem; something is passing gmake
options to bmake.
We had a problem with this with -current owing to some inadvisable
modifications to make, but these shouldn't (AFAIK) affect you on 5.x
...and also I thought that mess had been fixed.
I don't see anything obvious in the package that should cause this
behavior, nor is the package set to require gmake. Do you maybe have
MFLAGS set in the environment?

I started poking at this again, and I think I see what's causing the
problem, although I don't know why.

NetBSD-5's 'make' is tripping over the following in ${WRKSRC}/Makefile:

MAKE_SUBDIR = for dir in $(SUBDIRS); do $(MAKE) -C $$dir $@ || exit 5; done

Looking at the error message, it appears NetBSD-5 'make' doesn't support
"-C directory".

This is the only package I've attempted to build that uses that feature.
The Makefile in the previous version of 'xscreensaver' didn't, IIRC.

I guess this means I need to install 'bmake' at a minimum, or go all
the way and install the bootstrap kit (treat netbsd-5 as a foreign
platform).

--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645

Thomas Klausner

2013-11-04 21:35:00 UTC

Permalink

The following reply was made to PR pkg/48224; it has been noted by GNATS.

From: Thomas Klausner <***@NetBSD.org>
To: NetBSD bugtracking <gnats-***@NetBSD.org>
Cc:
Subject: Re: pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on
netbsd-5/i386
Date: Mon, 4 Nov 2013 22:30:26 +0100

Post by John D. Baker
Looking at the error message, it appears NetBSD-5 'make' doesn't support
"-C directory".

Does adding
USE_TOOLS+= gmake
fix this?
(GNU make supports -C.)
Thomas

David Holland

2013-11-05 06:25:00 UTC

Permalink

Post by David Holland
Subject: Re: pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on
netbsd-5/i386
Date: Mon, 4 Nov 2013 22:30:26 +0100

Post by John D. Baker
Looking at the error message, it appears NetBSD-5 'make' doesn't support
"-C directory".

Does adding
USE_TOOLS+= gmake
fix this?
(GNU make supports -C.)

Alternatively, you can patch like this:

- $(MAKE) -C $$dir $@
+ (cd $$dir && $(MAKE) $@)

I hadn't realized bmake had grown support for -C, actually.

--
David A. Holland
***@netbsd.org

John D. Baker

2013-11-05 06:50:01 UTC

Permalink

Post by Thomas Klausner

Post by John D. Baker
Looking at the error message, it appears NetBSD-5 'make' doesn't support
"-C directory".

Does adding
USE_TOOLS+= gmake
fix this?
(GNU make supports -C.)

Yes, this allows it to build. I added it to "Makefile" as the only
other user of "Makefile.common" is "xscreensaver-demo" which doesn't
use any features unsupported by netbsd-5 'make'.

Unless there is reason to do otherwise, it should likely be made
conditional on being built on a netbsd-5* host.

--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645

John D. Baker

2013-11-05 07:25:00 UTC

Permalink

The following reply was made to PR pkg/48224; it has been noted by GNATS.

From: "John D. Baker" <***@mylinuxisp.com>
To: gnats-***@NetBSD.org
Cc:
Subject: Re: pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on
netbsd-5/i386
Date: Tue, 5 Nov 2013 01:21:49 -0600 (CST)
Yes, this works (and I think a more elegant solution).

Patch in both places, in "Makefile.in":

+--- Makefile.in.orig 2013-02-05 00:46:07.000000000 -0600
++++ Makefile.in 2013-11-05 01:15:16.000000000 -0600
+@@ -19,8 +19,8 @@
+
+ TAR = tar
+
+-MAKE_SUBDIR = for dir in $(SUBDIRS); do $(MAKE) -C $$dir $@ || exit 5; done
+-MAKE_SUBDIR2 = for dir in $(SUBDIRS2); do $(MAKE) -C $$dir $@ || exit 5; done
++MAKE_SUBDIR = for dir in $(SUBDIRS); do (cd $$dir && $(MAKE) $@) || exit 5; done
++MAKE_SUBDIR2 = for dir in $(SUBDIRS2); do (cd $$dir && $(MAKE) $@) || exit 5; done
+
+ default::
+ @$(MAKE_SUBDIR)

--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645

OBATA Akio

2013-11-11 13:10:00 UTC

Permalink

The following reply was made to PR pkg/48224; it has been noted by GNATS.

From: "OBATA Akio" <***@netbsd.org>
To: gnats-***@gnats.NetBSD.org
Cc:
Subject: PR/48224 CVS commit: pkgsrc/x11/xscreensaver
Date: Mon, 11 Nov 2013 13:07:23 +0000

Module Name: pkgsrc
Committed By: obache
Date: Mon Nov 11 13:07:23 UTC 2013

Modified Files:
pkgsrc/x11/xscreensaver: distinfo
Added Files:
pkgsrc/x11/xscreensaver/patches: patch-Makefile.in

Log Message:
prevent to use gmake-izm.
fixes PR pkg/48224.

To generate a diff of this commit:
cvs rdiff -u -r1.64 -r1.65 pkgsrc/x11/xscreensaver/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/x11/xscreensaver/patches/patch-Makefile.in

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

OBATA Akio

2013-11-11 13:15:00 UTC

Permalink

The following reply was made to PR pkg/48224; it has been noted by GNATS.

From: "OBATA Akio" <***@netbsd.org>
To: gnats-***@netbsd.org
Cc:
Subject: Re: pkg/48224: x11/xscreensaver can't find GTK, GDK-Pixbuf on
netbsd-5/i386
Date: Mon, 11 Nov 2013 22:13:54 +0900

Post by John D. Baker
+--- Makefile.in.orig 2013-02-05 00:46:07.000000000 -0600
++++ Makefile.in 2013-11-05 01:15:16.000000000 -0600
+
+ TAR = tar
+
+

Applied the patch and build fine on NetBSD-5 now.

But as the charter of this PR, do you still want to add GTK/GDK-Pixbuf support?

--
OBATA Akio / ***@NetBSD.org

John D. Baker

2013-11-11 14:50:00 UTC

Permalink

Post by OBATA Akio
Applied the patch and build fine on NetBSD-5 now.
But as the charter of this PR, do you still want to add GTK/GDK-Pixbuf support?

As noted earlier, this was a mistaken assumption on my part. That
behavior is the same on netbsd-6 and -current.

The real issue turned out to be the gmake-ism that tripped up netbsd-5
"make", but for which netbsd-6+ "make" had added support.

So, no the GTK/GDK-Pixbuf support is apparently not an issue for
xscreensaver itself, but only the xscreensaver-demo package.

How should this be handled? Close this PR and open a more appropriately
named one and copy the relevant transactions to it?

--
|/"\ John D. Baker, KN5UKS NetBSD Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com OpenBSD FreeBSD
| X No HTML/proprietary data in email. BSD just sits there and works!
|/ \ GPGkeyID: D703 4A7E 479F 63F8 D3F4 BD99 9572 8F23 E4AD 1645

David Holland

2013-11-11 20:20:00 UTC

Permalink

Post by John D. Baker
So, no the GTK/GDK-Pixbuf support is apparently not an issue for
xscreensaver itself, but only the xscreensaver-demo package.
How should this be handled? Close this PR and open a more appropriately
named one and copy the relevant transactions to it?

Yeah. There doesn't seem to be much, as most of the traffic's been
about the build failure.

FWIW, xscreensaver-demo works for me.

--
David A. Holland
***@netbsd.org

o***@NetBSD.org

2013-11-12 01:06:53 UTC

Permalink

Synopsis: x11/xscreensaver can't find GTK, GDK-Pixbuf on netbsd-5/i386

State-Changed-From-To: open->closed
State-Changed-By: ***@NetBSD.org
State-Changed-When: Tue, 12 Nov 2013 01:06:53 +0000
State-Changed-Why:
Original build failure is fixed.