Discussion:
pkg/48555 (security/dirmngr rc script broken)
d***@NetBSD.org
2014-07-13 01:14:56 UTC
Permalink
Synopsis: security/dirmngr rc script broken

Responsible-Changed-From-To: misc-bug-people->pkg-manager
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Sun, 13 Jul 2014 01:14:56 +0000
Responsible-Changed-Why:
As best as we can tell, the problem is that security/dirmngr's rc script is
broken. I've updated the Synopsis: accordingly.
David Holland
2014-10-16 04:50:03 UTC
Permalink
The following reply was made to PR pkg/48555; it has been noted by GNATS.

From: David Holland <dholland-***@netbsd.org>
To: gnats-***@NetBSD.org
Cc: ***@tx.rr.com
Subject: Re: misc/48555: rc.conf handling of program=yes/no
Date: Thu, 16 Oct 2014 04:48:11 +0000
Is this dirmngr from pkgsrc/security/dirmngr? Try changing
line 56 of /etc/rc.d/dirmngr from
eval `${dirmngr_command} ${rc_flags}`
to
eval "${dirmngr_command} ${rc_flags}"
(double quotes instead of backticks). I have not tested this, but
it's possible that it will help.
Backticks are definitely wrong here. Eval is unnecessary. And
required_* stuff is handled by run_rc_command already. check_process
should be used too instead of doing it manually.
So I'd say, recategorize this against pkgsrc to fix the rc.d file.
On digging some, it seems that the backticks are there because
dirmngr, instead of doing something sane like writing out a pid file,
prints "export DIRMNGR_INFO=blahblahblah" when it daemonizes, so
you're supposed to eval this in the parent shell.

So that's not it - or at least not overtly. Also, this isn't run at
shutdown time, although part of the output from this is passed to kill
in dirmngr_stop and who knows what glop might have got into this.

To the original submitter if you're still there: what ends up in
/tmp/dirmngr/dirmngr.info after dirmngr starts (using this rc script)?

On a further matter, it is not clear where the additional wrapper
program in files/runDirmngr.c came from but a quick inspection shows
it has a bug or two...

--
David A. Holland
***@netbsd.org
David A. Holland
2014-10-16 04:55:00 UTC
Permalink
The following reply was made to PR pkg/48555; it has been noted by GNATS.

From: "David A. Holland" <***@netbsd.org>
To: gnats-***@gnats.NetBSD.org
Cc:
Subject: PR/48555 CVS commit: pkgsrc/security/dirmngr/files
Date: Thu, 16 Oct 2014 04:51:08 +0000

Module Name: pkgsrc
Committed By: dholland
Date: Thu Oct 16 04:51:08 UTC 2014

Modified Files:
pkgsrc/security/dirmngr/files: dirmngr.sh

Log Message:
Don't hand-process $required_dirs and $required_files. This is provided
by the infrastructure. Tangentially related to PR 48555.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 pkgsrc/security/dirmngr/files/dirmngr.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Loading...