pkg/49082: Unbreak lang/tcl on OS X Tiger

Discussion:

v***@geeklan.co.uk

2014-08-07 02:20:00 UTC

Number: 49082
Category: pkg
Synopsis: Unbreak lang/tcl on OS X Tiger
Confidential: no
Severity: non-critical
Priority: low
Responsible: pkg-manager
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Thu Aug 07 02:20:00 +0000 2014
Originator: Sevan Janiyan
Release: pkgsrc-current

Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007;
root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
TCL includes its own copy of sqlite, apply the same flags as databases/sqlite3 to handle building on Tiger as it doesn't have gethostuuid(2) and lacks the zone memory allocator
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/tcl/Makefile,v
retrieving revision 1.77
diff -u -r1.77 Makefile
--- Makefile 13 Mar 2014 11:08:51 -0000 1.77
+++ Makefile 7 Aug 2014 02:13:33 -0000
@@ -36,6 +36,13 @@
CONFIGURE_ARGS+= --enable-64bit
.endif

+# Darwin < 9 (Mac OS X < 10.5 "Leopard") doesn't have gethostuuid(2)
+# and lacks the zone memory allocator
+.if !empty(MACHINE_PLATFORM:MDarwin-[0-8].*-*)
+CFLAGS+= -DSQLITE_ENABLE_LOCKING_STYLE=0
+CPPFLAGS+= -DSQLITE_WITHOUT_ZONEMALLOC
+.endif
+
SUBST_CLASSES+= tcl-config
SUBST_STAGE.tcl-config= post-build
SUBST_FILES.tcl-config= unix/tclConfig.sh

Thomas Klausner

2014-08-07 06:45:01 UTC

Permalink

The following reply was made to PR pkg/49082; it has been noted by GNATS.

From: Thomas Klausner <***@NetBSD.org>
To: NetBSD bugtracking <gnats-***@NetBSD.org>
Cc:
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Thu, 7 Aug 2014 08:41:34 +0200

Post by v***@geeklan.co.uk
TCL includes its own copy of sqlite

Can we make it use pkgsrc's version instead?
Thomas

venture37

2014-08-07 14:02:08 UTC

Permalink

Post by Thomas Klausner
Can we make it use pkgsrc's version instead?

sure, the sqlite3 extension has a --with-system-sqlite option, will
get it tested out & follow up with a new diff.

venture37

2014-08-07 14:05:01 UTC

Permalink

The following reply was made to PR pkg/49082; it has been noted by GNATS.

From: venture37 <***@geeklan.co.uk>
To: gnats-***@NetBSD.org, pkg-***@netbsd.org,
gnats-***@netbsd.org, pkgsrc-***@netbsd.org
Cc:
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Thu, 07 Aug 2014 15:02:08 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Post by Thomas Klausner
Can we make it use pkgsrc's version instead?

sure, the sqlite3 extension has a --with-system-sqlite option, will
get it tested out & follow up with a new diff.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJT44bgAAoJENE/+DdOy3tC8k0P/1PmnWnOQ+1Wt9GqHkTpaa3I
m2+aUQEa8Pv1EGPVQYeCFz/OQzbznnKR0LwhDw4mRXVDzs56+xCOLZiIoddleeap
YUIjXTMmAxxmR3DRHT0gJMK4Wl9psz82903Y7s/qXFNWpXwQpEPieS8a9qfZsWez
zb7s1nHJJ1AU8RLfhlEd5yn2YO7JiyR0tUrwFjnvvg64q5Beq+9yendT4QmMBBlJ
BQA9LgGcQYlLesXzGhvLVBPDMWsg745AEjdNj2yZA/OiylFBPXaDRcI8mjhzADih
/hKKOnhjn2iewZlzZmHGFv1gBd5piVReXLwY44tdHfSDGeHYkmwhJkz4uYb37ofc
O6LpVUHuMtSj94o2P9EOq/yKm0w70Ag44byVscgoC1Co/BiKX7IvIswWbmMgLMJd
bg9Cl4Lr7ao1Nbg/Kyf0aZcHpWYaHP4/0HvpRKAGexc8ukDsncQcsMSYcBUnhHSt
Msb3HRiBC3B+Id5NkL83A54HrSbbMQnTfqQshjZWZ72JlqfGdj9hLLDaGVlYAe9c
FzvYV9fHUV44ld3GtSfLgMbzt39+atOZTKgzf6L9Gr1tVPiy453gIQcnq0U1lu9o
IOaHeKZWijjjK8NKEmGTVmQFKb5fp4yhjm9vg5FCjjjsfSge9DmnwNEz8yC+E6IM
biCZOQ5Df+qHmtkOIPwm
=4pJh
-----END PGP SIGNATURE-----

venture37

2014-08-08 01:38:35 UTC

Permalink

Post by venture37
sure, the sqlite3 extension has a --with-system-sqlite option, will
get it tested out & follow up with a new diff.

looking in work/tcl8.6.1/pkgs/sqlite3.8.0/configure I found

#--------------------------------------------------------------------
# The --with-system-sqlite causes the TCL bindings to SQLite to use
# the system shared library for SQLite rather than statically linking
# against its own private copy. This is dangerous and leads to
# undersirable dependences and is not recommended.
# Patchs from rmax.
#--------------------------------------------------------------------

Probably best to stick with building the private copy?

Sevan

venture37

2014-08-08 01:40:01 UTC

Permalink

Post by venture37
sure, the sqlite3 extension has a --with-system-sqlite option, will
get it tested out & follow up with a new diff.

David Holland

2014-08-08 05:25:01 UTC

Permalink

The following reply was made to PR pkg/49082; it has been noted by GNATS.

From: David Holland <dholland-***@netbsd.org>
To: gnats-***@NetBSD.org
Cc:
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Fri, 8 Aug 2014 05:20:58 +0000

Post by venture37
looking in work/tcl8.6.1/pkgs/sqlite3.8.0/configure I found
#--------------------------------------------------------------------
# The --with-system-sqlite causes the TCL bindings to SQLite to use
# the system shared library for SQLite rather than statically linking
# against its own private copy. This is dangerous and leads to
# undersirable dependences and is not recommended.
# Patchs from rmax.
#--------------------------------------------------------------------
Probably best to stick with building the private copy?

Would be nice if they bothered to explain why they think it's
dangerous...

--
David A. Holland
***@netbsd.org

venture37

2014-10-08 00:54:55 UTC

Permalink

Post by David Holland

Would be nice if they bothered to explain why they think it's
dangerous...

Looks like it's a generic warning so that tcl is isolated from system
upgrades.

Response from devs on IRC:
"simply put, you don't control the system sqlite or when it gets
upgraded or possibly breaking the interfaces you're using."

So TCL could be switched to use --with-system-sqlite.

I'll follow up with a new patch later this week.

venture37

2014-10-08 01:00:01 UTC

Permalink

Post by David Holland

Would be nice if they bothered to explain why they think it's
dangerous...