pkg/49118: update ap-auth-kerb to build for apache 2.

[n***@elys.com]

Number: 49118
Category: pkg
Synopsis: update ap-auth-kerb to build for apache 2.
Confidential: no
Severity: non-critical
Priority: medium
Responsible: pkg-manager
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Fri Aug 15 15:25:00 +0000 2014
Originator: Nahum Shalman
Release: pkgsrc 2014Q2 and earlier

Elysium Digital, L.L.C.
SmartOS (SunOS shalman.org 5.11 joyent_20140710T182029Z i86pc i386 i86pc Solaris)
The Makefile for ap-auth-kerb doesn't currently support apache24.

The patches from the Fedora project appear to fix the build.
http://pkgs.fedoraproject.org/cgit/mod_auth_kerb.git/tree/

The spec file applies them in this order:
Patch1: mod_auth_kerb-5.4-rcopshack.patch
Patch2: mod_auth_kerb-5.4-fixes.patch
Patch3: mod_auth_kerb-5.4-s4u2proxy.patch
Patch4: mod_auth_kerb-5.4-httpd24.patch
Patch5: mod_auth_kerb-5.4-delegation.patch
Patch6: mod_auth_kerb-5.4-cachedir.patch
Patch7: mod_auth_kerb-5.4-longuser.patch
Patch8: mod_auth_kerb-5.4-handle-continue.patch

I have converted those patches (plus the original
pkgsrc one) into a pair of per-file patches.

I also explicitly force the use of the pkgsrc
kerberos library on SunOS because the platform
kerberos doesn't work to build let alone run
this package
1. Install pkgsrc
2. Install apache24
3. Try to install mod_auth_kerb for apache24
4. Experience sadness.
My proposed patch can be retrieved raw from here:
https://github.com/nshalman/pkgsrc/commit/6c98bfb520b6ed4a8eb0f6f37b0967a49e7e0ef8.patch

[w***@NetBSD.org]

Synopsis: update ap-auth-kerb to build for apache 2.

Responsible-Changed-From-To: pkg-manager->markd
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Fri, 15 Aug 2014 15:26:14 +0000
Responsible-Changed-Why:
Over to maintainer.

[Mark Davies]

The following reply was made to PR pkg/49118; it has been noted by GNATS.

From: Mark Davies <***@ecs.vuw.ac.nz>
To: gnats-***@netbsd.org
Cc:
Subject: Re: pkg/49118: update ap-auth-kerb to build for apache 2.
Date: Sat, 16 Aug 2014 13:12:46 +1200

Post by n***@elys.com
The Makefile for ap-auth-kerb doesn't currently support apache24.

spz already applied a patch for apache24. Was that not sufficient?

cheers
mark

[Nahum Shalman]

Whoops. I'd been maintaining this patch against Joyent's downstream
since February and hoping that they would shepherd it upstream for me.
spz's patch wasn't in 2014Q2 which is what I was working off and I
wasn't watching pkgsrc trunk.

I will test spz's patch and report back. I have a feeling that I'll
still want to force SunOS to use pkgsrc with this snippet (or the
equivalent as written by someone who knows what they're doing...)

.include "../../mk/bsd.prefs.mk"
.if ${OPSYS} == "SunOS"
# native mit kerberos on SmartOS doesn't seem to work with this package
PREFER.mit-krb5?= pkgsrc
.endif

We can either track that in this PR or I can open a new one.

Either way, I have received your message that someone else has finally
written a patch. I will test it some time this week and report back.

Thanks so much!
Nahum

Post by Mark Davies
The following reply was made to PR pkg/49118; it has been noted by GNATS.
Subject: Re: pkg/49118: update ap-auth-kerb to build for apache 2.
Date: Sat, 16 Aug 2014 13:12:46 +1200

Post by n***@elys.com
The Makefile for ap-auth-kerb doesn't currently support apache24.

spz already applied a patch for apache24. Was that not sufficient?
cheers
mark

[Nahum Shalman]

The following reply was made to PR pkg/49118; it has been noted by GNATS.

From: Nahum Shalman <nshalman-***@elys.com>
To: gnats-***@NetBSD.org, ***@NetBSD.org, gnats-***@netbsd.org,
pkgsrc-***@netbsd.org
Cc:
Subject: Re: pkg/49118: update ap-auth-kerb to build for apache 2.
Date: Wed, 20 Aug 2014 10:49:26 -0400

Whoops. I'd been maintaining this patch against Joyent's downstream
since February and hoping that they would shepherd it upstream for me.
spz's patch wasn't in 2014Q2 which is what I was working off and I
wasn't watching pkgsrc trunk.

I will test spz's patch and report back. I have a feeling that I'll
still want to force SunOS to use pkgsrc with this snippet (or the
equivalent as written by someone who knows what they're doing...)

.include "../../mk/bsd.prefs.mk"
.if ${OPSYS} == "SunOS"
# native mit kerberos on SmartOS doesn't seem to work with this package
PREFER.mit-krb5?= pkgsrc
.endif

We can either track that in this PR or I can open a new one.

Either way, I have received your message that someone else has finally
written a patch. I will test it some time this week and report back.

Thanks so much!
Nahum

Post by Mark Davies
The following reply was made to PR pkg/49118; it has been noted by GNATS.
Subject: Re: pkg/49118: update ap-auth-kerb to build for apache 2.
Date: Sat, 16 Aug 2014 13:12:46 +1200

Post by n***@elys.com
The Makefile for ap-auth-kerb doesn't currently support apache24.

spz already applied a patch for apache24. Was that not sufficient?
cheers
mark

[d***@NetBSD.org]

Synopsis: update ap-auth-kerb to build for apache 2.

State-Changed-From-To: open->feedback
State-Changed-By: ***@NetBSD.org
State-Changed-When: Fri, 17 Oct 2014 06:55:06 +0000
State-Changed-Why:
Submitter is testing the alternative patch.