pkg/49271: SpamAssassin: patch-ay disables SPF, please remove it

[Petar Bogdanovic]

Number: 49271
Category: pkg
Synopsis: SpamAssassin: patch-ay disables SPF, please remove it
Confidential: no
Severity: non-critical
Priority: low
Responsible: pkg-manager
State: open
Class: sw-bug
Submitter-Id: net
Arrival-Date: Fri Oct 10 18:10:00 +0000 2014
Originator: Petar Bogdanovic
Release: NetBSD 6.0.6_PATCH

pkgsrc-2014Q3
Back in 2006, a default SA plugin (SpamAssassin::Plugin::SPF)
was disabled because of misleading warnings/errors:

http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=32514

just a few months later, the mentioned plugin was rewritten:

http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm?r1=440974&r2=486461&diff_format=h

the rewrite seems to have removed the errors and also added
support for Mail::SPF (now prefered to the old Mail::SPF::Query).

The original patch (patch-ay) should therefore be removed.
-
-

[t***@NetBSD.org]

Synopsis: SpamAssassin: patch-ay disables SPF, please remove it

Responsible-Changed-From-To: pkg-manager->tron
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Sat, 11 Oct 2014 19:43:31 +0000
Responsible-Changed-Why:
I'll try to handle this PR.

[t***@NetBSD.org]

Synopsis: SpamAssassin: patch-ay disables SPF, please remove it

Responsible-Changed-From-To: tron->pkg-manager
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Sat, 11 Oct 2014 19:50:33 +0000
Responsible-Changed-Why:
The "p5-Mail-SPF" package conflicts with the "libspf2" package. I can
therefore not install this on my mail server and as a result not test it.

[Petar Bogdanovic]

Post by t***@NetBSD.org
The "p5-Mail-SPF" package conflicts with the "libspf2" package. I can
therefore not install this on my mail server and as a result not test it.

They are not really in conflict, see the second part of this message:

https://mail-index.netbsd.org/pkgsrc-users/2014/07/04/msg019986.html

I tested SA without patch-ay and with libspf2 + p5-mail-spf installed. Its running on my MTA since 2014Q2.

[Petar Bogdanovic]

The following reply was made to PR pkg/49271; it has been noted by GNATS.

From: Petar Bogdanovic <***@smokva.net>
To: gnats-***@NetBSD.org,***@NetBSD.org,pkg-***@netbsd.org,***@NetBSD.org,pkgsrc-***@netbsd.org,gnats-***@netbsd.org,***@NetBSD.org
Cc:
Subject: Re: pkg/49271 (SpamAssassin: patch-ay disables SPF, please remove it)
Date: Sun, 12 Oct 2014 00:36:14 +0200

Post by t***@NetBSD.org
The "p5-Mail-SPF" package conflicts with the "libspf2" package. I can
therefore not install this on my mail server and as a result not test
it.

They are not really in conflict, see the second part of this message:

https://mail-index.netbsd.org/pkgsrc-users/2014/07/04/msg019986.html

I tested SA without patch-ay and with libspf2 + p5-mail-spf installed. Its running on my MTA since 2014Q2.

--
Sent from my phone.

[Matthias Scheler]

The following reply was made to PR pkg/49271; it has been noted by GNATS.

From: Matthias Scheler <***@NetBSD.org>
To: Petar Bogdanovic <***@smokva.net>
Cc: gnats-***@NetBSD.org
Subject: Re: pkg/49271 (SpamAssassin: patch-ay disables SPF, please remove it)
Date: Sun, 12 Oct 2014 09:11:02 +0100

Post by Petar Bogdanovic

Post by t***@NetBSD.org
The "p5-Mail-SPF" package conflicts with the "libspf2" package. I can
therefore not install this on my mail server and as a result not test
it.

https://mail-index.netbsd.org/pkgsrc-users/2014/07/04/msg019986.html

Indeed. "bin/spfd" vs. "sbin/spfd".

Kind regards

--
Matthias Scheler http://zhadum.org.uk/

[t***@NetBSD.org]

Synopsis: SpamAssassin: patch-ay disables SPF, please remove it

Responsible-Changed-From-To: pkg-manager->tron
Responsible-Changed-By: ***@NetBSD.org
Responsible-Changed-When: Sun, 12 Oct 2014 08:18:39 +0000
Responsible-Changed-Why:
I'll try again to handle this PR.

[Matthias Scheler]

The following reply was made to PR pkg/49271; it has been noted by GNATS.

From: "Matthias Scheler" <***@netbsd.org>
To: gnats-***@gnats.NetBSD.org
Cc:
Subject: PR/49271 CVS commit: pkgsrc/mail
Date: Sun, 12 Oct 2014 08:17:50 +0000

Module Name: pkgsrc
Committed By: tron
Date: Sun Oct 12 08:17:50 UTC 2014

Modified Files:
pkgsrc/mail/libspf-alt: Makefile
pkgsrc/mail/libspf2: Makefile
pkgsrc/mail/p5-Mail-SPF: Makefile

Log Message:
Remove conflict between "libspf-alt" respectively "libspf2" and
"p5-Mail-SPF". The first two packages install "bin/spfd" while the
latter install "sbin/spfd".

Problem pointed out by Petar Bogdanovic in PR pkg/49271.


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 pkgsrc/mail/libspf-alt/Makefile
cvs rdiff -u -r1.11 -r1.12 pkgsrc/mail/libspf2/Makefile
cvs rdiff -u -r1.7 -r1.8 pkgsrc/mail/p5-Mail-SPF/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

[Matthias Scheler]

The following reply was made to PR pkg/49271; it has been noted by GNATS.

From: "Matthias Scheler" <***@netbsd.org>
To: gnats-***@gnats.NetBSD.org
Cc:
Subject: PR/49271 CVS commit: pkgsrc/mail/spamassassin
Date: Sun, 12 Oct 2014 15:18:21 +0000

Module Name: pkgsrc
Committed By: tron
Date: Sun Oct 12 15:18:21 UTC 2014

Modified Files:
pkgsrc/mail/spamassassin: Makefile
Removed Files:
pkgsrc/mail/spamassassin/patches: patch-ay

Log Message:
Re-enable SPF support. The reason for disabling are no longer valid since
several years. Bump package revision because of this change.

Suggested by Petar Bogdanovic in PR pkg/49271.


To generate a diff of this commit:
cvs rdiff -u -r1.117 -r1.118 pkgsrc/mail/spamassassin/Makefile
cvs rdiff -u -r1.2 -r0 pkgsrc/mail/spamassassin/patches/patch-ay

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

[t***@NetBSD.org]

Synopsis: SpamAssassin: patch-ay disables SPF, please remove it

State-Changed-From-To: open->closed
State-Changed-By: ***@NetBSD.org
State-Changed-When: Sun, 12 Oct 2014 15:23:49 +0000
State-Changed-Why:
I've re-enable SPF support in the "spamassassin" package. Thanks a lot for
the very useful suggestion.